Change in vdsm[master]: vdsm: prepareVolumePath correct path handling for cdrom

danken at redhat.com danken at redhat.com
Wed Dec 11 16:01:33 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm: prepareVolumePath correct path handling for cdrom
......................................................................


vdsm: prepareVolumePath correct path handling for cdrom

prepareVolumePath looked for 'path' key in specParams
without looking at path in device itself, causing empty
path in specParams to override device path. This patch
adds device.path to checking mechanism to avoid overriding
valid path

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009469
Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9
Signed-off-by: Martin Polednik <mpoledni at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/20074
Reviewed-by: Michal Skrivanek <michal.skrivanek at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/clientIF.py
1 file changed, 7 insertions(+), 5 deletions(-)

Approvals:
  Federico Simoncelli: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Michal Skrivanek: Looks good to me, but someone else must approve
  Martin Polednik: Verified



-- 
To view, visit http://gerrit.ovirt.org/20074
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list