Change in vdsm[ovirt-3.3]: domainMonitor: Separate change detection from lastCheck value

ybronhei at redhat.com ybronhei at redhat.com
Wed Dec 11 09:12:49 UTC 2013


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: domainMonitor: Separate change detection from lastCheck value
......................................................................


domainMonitor: Separate change detection from lastCheck value

Since commit 45f3037ca1e, lastCheck value is initialized to special
NOT_CHECKED_YET value, and used for detecting the first monitor status change.
This change caused repoStats to return high lastCheck value until the first
monitor check is done, causing host activation to fail, and host becoming
non-operational.

Previously, lastCheck value was initialized to monitor thread creation time,
and repoStats was returning valid lastCheck value even before the first domain
check was finished. While somewhat incorrect, this behavior is required for
engine monitoring logic.

This patch restore the previous lastCheck semantics and use a new
firstChange flag for detecting the first status change.

Change-Id: I8e0df2ee0333354146b5d9429fd83a4f914ff751
Relates-To: https://bugzilla.redhat.com/1003588
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21878
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Liron Ar <laravot at redhat.com>
Reviewed-by: Ayal Baron <abaron at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22209
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Tested-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/storage/domainMonitor.py
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22209
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e0df2ee0333354146b5d9429fd83a4f914ff751
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list