Change in vdsm[master]: clientIF: Teardown volume path only for VDSM images

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 10 22:16:06 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: clientIF: Teardown volume path only for VDSM images
......................................................................


Patch Set 5:

(1 comment)

....................................................
File vdsm/vm.py
Line 81: 
Line 82: 
Line 83: def isVdsmImage(drive):
Line 84:     if hasattr(drive, "isVdsmImage"):
Line 85:         return drive.isVdsmImage()
Need also to check that drive.isVdsmImage() is correct - because it does not check all values checked bellow:

    def isVdsmImage(self):
        return getattr(self, 'poolID', False)

So either Drive.isVdsmImage() is not good enough or some of the checks bellow are not needed.
Line 86:     elif type(drive) is dict:
Line 87:         return all(k in drive.keys() for k in ('volumeID', 'domainID',
Line 88:                                                'imageID', 'poolID'))
Line 89:     else:


-- 
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list