Change in vdsm[master]: sampling: take storageDomains directly from storage subsys

danken at redhat.com danken at redhat.com
Tue Dec 10 21:16:54 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: sampling: take storageDomains directly from storage subsys
......................................................................


sampling: take storageDomains directly from storage subsys

HostStatsThread does not poll storageDomains statistics, but still it is
used to relay them from the storage subsystem to the getVdsStats api.
This is cumbersome and confusing. This patch eliminates the need to pass
a clientIF reference to the HostStatsThread, and keeps the knowledge of
which statistic elements are provided (code, delay, lastCheck, etc)
with the storage subsystem.

Change-Id: I1a86b828fdf43d74bf4475d2c6632c4511519356
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21334
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
---
M tests/functional/storageTests.py
M vdsm/API.py
M vdsm/clientIF.py
M vdsm/sampling.py
4 files changed, 16 insertions(+), 23 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21334
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a86b828fdf43d74bf4475d2c6632c4511519356
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list