Change in vdsm[master]: QoS: make report only when present and say so in the schema

danken at redhat.com danken at redhat.com
Tue Dec 10 20:02:08 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: QoS: make report only when present and say so in the schema
......................................................................


QoS: make report only when present and say so in the schema

Libvirt XML format specifies that bandwidth elements (inbound and
outbound) are only optionally present. When present they should
have an average and optionally have the fields 'burst' and 'peak'.

While this was correctly defined in the vdsm api schema for input
(setupNetworks for instance), it was not defined for the capabilities
reporting. That left a not well defined situation where no QoS was
defined and it was being included in the report without following
the specification in the paragraph above.

This patch fixes this inconsistency by reporting the bandwidth
elements only when present in the network definition, and only
containing those fields that are defined for them.

Change-Id: Id9d2bc8310fed2ad3c0a748cdf1cfd2cf050aa2f
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22018
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
---
M lib/vdsm/netinfo.py
M tests/functional/networkTests.py
M tests/functional/utils.py
M tests/netinfoTests.py
M vdsm_api/vdsmapi-schema.json
5 files changed, 49 insertions(+), 35 deletions(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22018
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id9d2bc8310fed2ad3c0a748cdf1cfd2cf050aa2f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list