Change in vdsm[master]: threadpool: Move iteration logic to it's own method
nsoffer at redhat.com
nsoffer at redhat.com
Tue Dec 10 16:09:01 UTC 2013
Nir Soffer has posted comments on this change.
Change subject: threadpool: Move iteration logic to it's own method
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Looks good
....................................................
File vdsm/storage/threadPool.py
Line 184: self.__pool = pool
Line 185: self.__isDying = False
Line 186: self.daemon = True
Line 187:
Line 188: def _processNextTask(self):
I would add a note about not keeping reference to the objects taken from the pool, in case someone will try to "optimize" this method into run again :-)
Line 189: id, cmd, args, callback = self.__pool.getNextTask()
Line 190: try:
Line 191: if id is None: # should retry.
Line 192: pass
--
To view, visit http://gerrit.ovirt.org/22263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a300682ce9e05a055a3534a935718cc73239acb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list