Change in vdsm[master]: vdsm: Add an exception for wrong master version.

laravot at redhat.com laravot at redhat.com
Tue Dec 10 07:49:10 UTC 2013


Liron Ar has posted comments on this change.

Change subject: vdsm: Add an exception for wrong master version.
......................................................................


Patch Set 3:

(1 comment)

....................................................
File vdsm/storage/storage_exception.py
Line 609:     code = 330
Line 610:     message = "Cannot get file stats"
Line 611: 
Line 612: 
Line 613: class StoragePoolWrongVersion(StorageException):
Actually this should cause regression with older engine the thrown exception would be IrsOperationFailedNoFailoverException, take a look in IrsBrokerCommand - executeVdsCommand, it won't trigger reconstruct as it used to.

the correct fix here should be to send the explicit error to the engine as the message text so we can have that info there.
Line 614:     def __init__(self, spUUID, sdUUID):
Line 615:         self.value = "SD=%s, pool=%s" % (sdUUID, spUUID)
Line 616:     code = 331
Line 617:     message = "Wrong Master version"


-- 
To view, visit http://gerrit.ovirt.org/21175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a7356c6ebc1aa15910725e0bd17faccd0858621
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list