Change in vdsm[ovirt-3.3]: vm: Fix exception when shutdown() called on vm in 'Down' state

gpadgett at redhat.com gpadgett at redhat.com
Mon Dec 9 22:42:39 UTC 2013


Hello Sandro Bonazzola, Federico Simoncelli, Doron Fediuck, Dan Kenigsberg, Michal Skrivanek,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/22218

to review the following change.

Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state
......................................................................

vm: Fix exception when shutdown() called on vm in 'Down' state

Attempting to call the shutdown() method on a VM which is in 'Down'
state resulted in an exception if called through xmlrpclib.  Instead,
adopt the convention used by similar APIs such as migrate() and return
errCode['noVM'].

Change-Id: I8b75d0b869354d503e5f187e33370b5837b3c698
Bug-Url: https://bugzilla.redhat.com/1027297
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21937
Reviewed-by: Sandro Bonazzola <sbonazzo at redhat.com>
Reviewed-by: Doron Fediuck <dfediuck at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-by: Michal Skrivanek <michal.skrivanek at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/22218/1

diff --git a/vdsm/vm.py b/vdsm/vm.py
index b9ab60b..59541e7 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -2483,7 +2483,7 @@
         try:
             now = time.time()
             if self.lastStatus == 'Down':
-                return
+                return errCode['noVM']
             if self.guestAgent and self.guestAgent.isResponsive():
                 self._guestEventTime = now
                 self._guestEvent = 'Powering down'


-- 
To view, visit http://gerrit.ovirt.org/22218
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b75d0b869354d503e5f187e33370b5837b3c698
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>


More information about the vdsm-patches mailing list