Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
Alon Bar-Lev
alonbl at redhat.com
Mon Dec 9 21:13:49 UTC 2013
Alon Bar-Lev has posted comments on this change.
Change subject: sanlock isconfigured raises an exception instead of returning result
......................................................................
Patch Set 4:
(1 comment)
....................................................
File lib/vdsm/tool/configurator.py
Line 138:
Line 139: def isconfigured(self, *args):
Line 140: """
Line 141: True if sanlock service requires a restart to reload the relevant
Line 142: supplementary groups.
False ?!?!?
Line 143: """
Line 144: ret = False
Line 145: try:
Line 146: with open("/var/run/sanlock/sanlock.pid", "r") as f:
--
To view, visit http://gerrit.ovirt.org/22184
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list