Change in vdsm[master]: hook: spiceoptions: To provide spice option attributes to vm
danken at redhat.com
danken at redhat.com
Mon Dec 9 14:35:56 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
partial review
....................................................
File vdsm_hooks/spiceoptions/before_vm_start.py
Line 42: strModeList = ['filter', 'all', 'off']
Line 43:
Line 44: mouseModeList = ['server', 'client']
Line 45:
Line 46: spiceDict = {'image': {'compression': imageCompList},
these are all CONSTANTS, and should be named as such.
Line 47: 'jpeg': {'compression': jpegCompList},
Line 48: 'streaming': {'mode': strModeList},
Line 49: 'mouse': {'mode': mouseModeList},
Line 50: 'clipboard': {'copypaste': copyPaste}}
Line 104: sys.stderr.write('\n No Valid Element created for graphic device :%s\n'
Line 105: % (attrname))
Line 106:
Line 107:
Line 108: if 'spiceoptions' in os.environ:
please split to main() and test() functions, and use hooking.py's hook_exit().
Line 109: try:
Line 110: attrName = ''
Line 111: attrVal = ''
Line 112: attrOpt = ''
--
To view, visit http://gerrit.ovirt.org/22178
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7761aab98cdc3a0d37bed7984ae540278e6bbf70
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Humble Devassy Chirammal <hchiramm at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Humble Devassy Chirammal <hchiramm at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list