Change in vdsm[master]: threadPool: Do not keep reference to tasks

danken at redhat.com danken at redhat.com
Mon Dec 9 14:24:06 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: threadPool: Do not keep reference to tasks
......................................................................


threadPool: Do not keep reference to tasks

Worker thread was taking a task from the threadpool queue, run it, and
then hold it until the next task is run. This causes the task and all
objects referenced from it to keep living until the next task is run by
this thread.

This patch ensure that worker thread does not keep referece to tasks
after they were run.

Change-Id: Ib6e024e0727e11a4c98f4e5ede20229d148fdc58
Relates-To: https://bugzilla.redhat.com/1032925
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22136
Reviewed-by: Ayal Baron <abaron at redhat.com>
Reviewed-by: Allon Mureinik <amureini at redhat.com>
---
M vdsm/storage/threadPool.py
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Nir Soffer: Verified
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/22136
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6e024e0727e11a4c98f4e5ede20229d148fdc58
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list