Change in vdsm[ovirt-3.3]: Allow setting just a single value in MoM policy

ybronhei at redhat.com ybronhei at redhat.com
Mon Dec 9 13:58:53 UTC 2013


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Allow setting just a single value in MoM policy
......................................................................


Allow setting just a single value in MoM policy

This patch prevents a policy coruption that could have happened
when the 01-parameters policy was updated with just a single
value. If there were more values defined, the variables were lost
and the policy ended up broken.

This patch defines the variables in a file that is not touched
by the setMOMPolicyParameters and uses (set name value) syntax
in the generated policy part.

It also remembers the old setting and puts all the values to
the policy part when it is autogenerated.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025780

Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8
Signed-off-by: Martin Sivak <msivak at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21225
Reviewed-by: Amador Pahim <apahim at redhat.com>
Reviewed-by: Doron Fediuck <dfediuck at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21839
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M debian/vdsm.install
M vdsm/Makefile.am
A vdsm/mom.d/00-defines.policy
D vdsm/mom.d/00-python.policy
M vdsm/mom.d/01-parameters.policy
M vdsm/momIF.py
6 files changed, 17 insertions(+), 11 deletions(-)

Approvals:
  Martin Sivák: Verified
  Yaniv Bronhaim: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21839
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list