Change in vdsm[master]: hook: spiceoptions: To provide spice option attributes to vm

tjeyasin at redhat.com tjeyasin at redhat.com
Mon Dec 9 07:06:18 UTC 2013


Timothy Asir has posted comments on this change.

Change subject: hook: spiceoptions: To provide spice option attributes to vm
......................................................................


Patch Set 2:

(4 comments)

....................................................
File vdsm.spec.in
Line 535: 
Line 536: %description hook-spiceoptions
Line 537: This vdsm hook can be used to configure some of 
Line 538: the spice optimization attributes and values..
Line 539: 
remove this extra white space
Line 540: %package hook-vmfex
Line 541: Summary:        vmfex support for VDSM
Line 542: BuildArch:      noarch
Line 543: 


Line 1236: 
Line 1237: 
Line 1238: %files hook-spiceoptions
Line 1239: %defattr(-, root, root, -)
Line 1240: %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/60_spiceoptions
hope it should be "%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_spiceoptions"
Line 1241: 
Line 1242: %files hook-vmdisk
Line 1243: %defattr(-, root, root, -)
Line 1244: %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_vmdisk


....................................................
File vdsm_hooks/Makefile.am
Line 40: 	qos \
Line 41: 	scratchpad \
Line 42: 	smbios \
Line 43: 	sriov \
Line 44: 	spiceoptions \
please keep this in sorted order.
Line 45: 	vmdisk \
Line 46: 	vmfex
Line 47: endif
Line 48: 


....................................................
File vdsm_hooks/spiceoptions/README
Line 43:    spiceoptions={'image': {'compression': 'auto_glz'},
Line 44: 		 'jpeg': {'compressions': 'never'}, 
Line 45: 		 'streaming':{'mode':'filter'}, 
Line 46: 		 'clipboard':{'copypaste':'yes'}}..etc
Line 47: 
Remove this extra white spaces
Line 48: 
Line 49: Installation:
Line 50: * Use the engine-config to append the appropriate custom property as such:
Line 51: 	sudo engine-config -s UserDefinedVMProperties=


-- 
To view, visit http://gerrit.ovirt.org/22178
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7761aab98cdc3a0d37bed7984ae540278e6bbf70
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Humble Devassy Chirammal <hchiramm at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list