Change in vdsm[master]: threadPool: Do not keep reference to tasks

amureini at redhat.com amureini at redhat.com
Sun Dec 8 14:03:13 UTC 2013


Allon Mureinik has posted comments on this change.

Change subject: threadPool: Do not keep reference to tasks
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

+1 on the code, please fix the commit message

....................................................
Commit Message
Line 5: CommitDate: 2013-12-08 00:49:36 +0200
Line 6: 
Line 7: threadPool: Do not keep reference to tasks
Line 8: 
Line 9: WorkerThread used to take a task from the threadpool queue, run it, and
s/used/was used/
Line 10: then hold it until the next task is run. This cause task and all objects
Line 11: referenced from it to keep living unti the next task is run by this
Line 12: thread. This patch ensure that task are deleted after they are run.
Line 13: 


Line 6: 
Line 7: threadPool: Do not keep reference to tasks
Line 8: 
Line 9: WorkerThread used to take a task from the threadpool queue, run it, and
Line 10: then hold it until the next task is run. This cause task and all objects
s/cause task/causes the task/
Line 11: referenced from it to keep living unti the next task is run by this
Line 12: thread. This patch ensure that task are deleted after they are run.
Line 13: 
Line 14: Change-Id: Ib6e024e0727e11a4c98f4e5ede20229d148fdc58


Line 7: threadPool: Do not keep reference to tasks
Line 8: 
Line 9: WorkerThread used to take a task from the threadpool queue, run it, and
Line 10: then hold it until the next task is run. This cause task and all objects
Line 11: referenced from it to keep living unti the next task is run by this
s/unti/until/
Line 12: thread. This patch ensure that task are deleted after they are run.
Line 13: 
Line 14: Change-Id: Ib6e024e0727e11a4c98f4e5ede20229d148fdc58
Line 15: Relates-To: https://bugzilla.redhat.com/1032925


-- 
To view, visit http://gerrit.ovirt.org/22136
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6e024e0727e11a4c98f4e5ede20229d148fdc58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list