Change in vdsm[master]: Introduce util.isOvirtNode()

nsoffer at redhat.com nsoffer at redhat.com
Sat Dec 7 01:11:42 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: Introduce util.isOvirtNode()
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/storage/misc.py
Line 506: 
Line 507:     for key in keys:
Line 508:         oldName = os.path.join(directory, fd[key]['old'])
Line 509:         newName = os.path.join(directory, fd[key]['new'])
Line 510:         if utils.isOvirtNode() and persist and not cp:
This would read much better if this function is in module named "host":

    import host
    ...
    if host.isOvirtNode():
        ...

There are probably other functions that would like to live there as well.
Line 511:             try:
Line 512:                 execCmd([constants.EXT_UNPERSIST, oldName], logErr=False,
Line 513:                         sudo=True)
Line 514:                 execCmd([constants.EXT_UNPERSIST, newName], logErr=False,


-- 
To view, visit http://gerrit.ovirt.org/20809
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6da5c94b5a8c11eace4813530570380c651e6d88
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list