Change in vdsm[master]: utils: janitorial: refactor utils.readMemInfo

danken at redhat.com danken at redhat.com
Fri Dec 6 19:31:47 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: utils: janitorial: refactor utils.readMemInfo
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

....................................................
File lib/vdsm/utils.py
Line 194:             with open('/proc/meminfo') as f:
Line 195:                 lines = f.readlines()
Line 196:                 return _parseMemInfo(lines)
Line 197:         except:
Line 198:             logging.warning(lines, exc_info=True)
Could you see if we ever get this error nowadays? (Unrelated to patch)
Line 199:             if tries <= 0:
Line 200:                 raise
Line 201:             time.sleep(0.1)
Line 202: 


-- 
To view, visit http://gerrit.ovirt.org/22041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife98134e4512613fb9812f3162c7cd6a4af8fc89
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list