Change in vdsm[master]: Introduce util.isOvirtNode()

Alon Bar-Lev alonbl at redhat.com
Fri Dec 6 17:55:59 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: Introduce util.isOvirtNode()
......................................................................


Patch Set 2:

(1 comment)

....................................................
File lib/vdsm/utils.py
Line 1059: @memoized
Line 1060: def isOvirtNode():
Line 1061:     return (
Line 1062:         os.path.exists('/etc/rhev-hypervisor-release') or
Line 1063:         glob.glob('/etc/ovirt-node-*-release')
well, /me/ not python expert, but this returns non bool...

 print(False or ['x',])
 ['x']

I use:

                os.path.exists('/etc/rhev-hypervisor-release') or
                bool(glob.glob('/etc/ovirt-node-*-release'))


-- 
To view, visit http://gerrit.ovirt.org/20809
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6da5c94b5a8c11eace4813530570380c651e6d88
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list