Change in vdsm[master]: ip monitor: replace pairwise with grouper

danken at redhat.com danken at redhat.com
Fri Dec 6 15:25:12 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: ip monitor: replace pairwise with grouper
......................................................................


ip monitor: replace pairwise with grouper

pairwise takes an iterator or elements '123456789' and generates an
iterator that gives: ('1', '2'), ('2', '3'), ('3', '4'), ('4', '5')...

grouper takes an iterator or elements '123456789' and generates an
iterator that gives: [('1', '2'), ('3', '4'), ('5', '6'), ('7', '8'), ('9',
None)]

Since the data to parse from iproute2 commands is structured closer
to grouper, change to that.

Change-Id: Ie1c569cee85c2d4fd54cbd8e6d964c2291056c6c
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22092
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/ipwrapper.py
M lib/vdsm/utils.py
M tests/utilsTests.py
3 files changed, 27 insertions(+), 9 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22092
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1c569cee85c2d4fd54cbd8e6d964c2291056c6c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list