Change in vdsm[master]: ksm: janitorial: with construct, file() to open()

danken at redhat.com danken at redhat.com
Fri Dec 6 13:14:36 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: ksm: janitorial: with construct, file() to open()
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

....................................................
File tests/miscTests.py
Line 30: import inspect
Line 31: from multiprocessing import Process
Line 32: from vdsm import utils
Line 33: 
Line 34: import ksm
miscTests is named after storage/misc.py. Please use a new ksmTests.py.
Line 35: import storage.outOfProcess as oop
Line 36: import storage.misc as misc
Line 37: import storage.fileUtils as fileUtils
Line 38: from testValidation import checkSudo


Line 1318:     def testReadProcValid(self):
Line 1319:         # we need a procfs entry which exists on every system and
Line 1320:         # with a predictable value.
Line 1321:         threadsMax = ksm._readProcFSInt('/proc/sys/kernel/threads-max')
Line 1322:         self.assertTrue(threadsMax > 0)
assetLess gives better output on failure.


-- 
To view, visit http://gerrit.ovirt.org/22084
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47213b3d85eac9afd4cb316c50b192b9c1dfbbd8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list