Change in vdsm[master]: vdsm: Hardware information about POWER hosts

vitor.lima at eldorado.org.br vitor.lima at eldorado.org.br
Thu Dec 5 17:59:18 UTC 2013


Vitor de Lima has posted comments on this change.

Change subject: vdsm: Hardware information about POWER hosts
......................................................................


Patch Set 6:

(2 comments)

....................................................
File build-aux/config.sub
Line 1: #! /bin/sh
Line 2: # Configuration validation subroutine script.
Line 3: #   Copyright 1992-2013 Free Software Foundation, Inc.
The automatic script that builds and installs RPMs required these two files because of the AC_CANONICAL_HOST in the configure.ac file. The strange thing is that they weren't needed in my Fedora 19 setup. Should these files be redistributed with the VDSM source code? The autogen.sh script populates the source tree with these files in my machines.
Line 4: 
Line 5: timestamp='2013-04-24'
Line 6: 
Line 7: # This file is free software; you can redistribute it and/or modify it


....................................................
File debian/vdsm.install
Line 131: ./usr/share/vdsm/vdsm-store-net-config
Line 132: ./usr/share/vdsm/vdsmDebugPlugin.py
Line 133: ./usr/share/vdsm/vdsmapi-schema.json
Line 134: ./usr/share/vdsm/vm.py
Line 135: #TODO: add ppc64HardwareInfo.py for ppc64
I have no idea how to include this file in the debian package only when building for ppc64 hosts. If someone can point out how to do this, I will be thankful.
Line 136: ./usr/share/vdsm/vmChannels.py


-- 
To view, visit http://gerrit.ovirt.org/19395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list