Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value

laravot at redhat.com laravot at redhat.com
Thu Dec 5 12:58:12 UTC 2013


Liron Ar has posted comments on this change.

Change subject: domainMonitor: Separate change detection from lastCheck value
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

....................................................
File vdsm/storage/domainMonitor.py
Line 249:             except:
Line 250:                 self.log.warn("Could not emit domain state change event",
Line 251:                               exc_info=True)
Line 252: 
Line 253:         self.firstChange = False
mixed between the initialization and the set here.
Line 254: 
Line 255:         # An ISO domain can be shared by multiple pools
Line 256:         if (not self.isIsoDomain and self.nextStatus.valid
Line 257:                 and self.nextStatus.hasHostId is False):


-- 
To view, visit http://gerrit.ovirt.org/21878
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e0df2ee0333354146b5d9429fd83a4f914ff751
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list