Change in vdsm[master]: vm: Fix exception when shutdown() called on vm in 'Down' state

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Wed Dec 4 12:25:18 UTC 2013


Michal Skrivanek has posted comments on this change.

Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

note this patch is going to be obsoleted by http://gerrit.ovirt.org/#/c/15829/ so it doesn't make much sense for master
however for the time being it's ok

....................................................
File vdsm/vm.py
Line 2487:     def shutdown(self, timeout, message):
Line 2488:         try:
Line 2489:             now = time.time()
Line 2490:             if self.lastStatus == 'Down':
Line 2491:                 return errCode['noVM']
OTOH after the mentione patch you'll be getting noVM as the VM obejct would be destroyed as part of shutdown….and since the usage is not really consistent ATM it's probably better to keep noVM here
Line 2492:             if self.guestAgent and self.guestAgent.isResponsive():
Line 2493:                 self._guestEventTime = now
Line 2494:                 self._guestEvent = 'Powering down'
Line 2495:                 self.log.debug('guestAgent shutdown called')


-- 
To view, visit http://gerrit.ovirt.org/21937
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b75d0b869354d503e5f187e33370b5837b3c698
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list