Change in vdsm[master]: Teardown only VDSM images when power-off VM

sgotliv at redhat.com sgotliv at redhat.com
Wed Dec 4 08:16:20 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: Teardown only VDSM images when power-off VM
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/vm.py
Line 2537:                                      "for drive %s", drive, exc_info=True)
Line 2538:                     # Skip any exception as we don't want to interrupt the
Line 2539:                     # teardown process for any reason.
Line 2540:                 try:
Line 2541:                     if drive.isVdsmImage():
Michal, it doesn't contain this check. I also agree with Federico - the fix in this method will be better, but supporting 4 different input types is the huge mistake in the first place.

def teardownVolumePath(self, drive):
        res = {'status': doneCode}
        try:
            res = self.irs.teardownImage(drive['domainID'],
                                         drive['poolID'], drive['imageID'])
        except (KeyError, TypeError):
            # paths (strings) are not deactivated
            if not isinstance(drive, basestring):
                self.log.warning("Drive is not a vdsm image: %s",
                                 drive, exc_info=True)

        return res['status']['code']
Line 2542:                         self.cif.teardownVolumePath(drive)
Line 2543:                 except:
Line 2544:                     self.log.error("Drive teardown failure for %s",
Line 2545:                                    drive, exc_info=True)


-- 
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list