Change in vdsm[master]: Teardown only VDSM images when power-off VM

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 4 01:23:13 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: Teardown only VDSM images when power-off VM
......................................................................


Patch Set 2:

(2 comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-12-03 17:57:47 +0200
Line 4: Commit:     Sergey Gotliv <sgotliv at redhat.com>
Line 5: CommitDate: 2013-12-03 18:21:00 +0200
Line 6: 
Line 7: Teardown only VDSM images when power-off VM
powering-off a VM?
Line 8: 
Line 9: Trying to tear down a cdrom or external lun throws an exception which
Line 10: creates a lot of log printings.
Line 11: 


....................................................
File vdsm/vm.py
Line 2537:                                      "for drive %s", drive, exc_info=True)
Line 2538:                     # Skip any exception as we don't want to interrupt the
Line 2539:                     # teardown process for any reason.
Line 2540:                 try:
Line 2541:                     if drive.isVdsmImage():
teardownVolumePath is too broken. It tries to support too many input parameter types: dict, Drive object, str and None. All this type checking is done implicitly by the try-except. We should have only *one* type of object representing a drive. Until this is fixed, it is better to do keep away from that code.
Line 2542:                         self.cif.teardownVolumePath(drive)
Line 2543:                 except:
Line 2544:                     self.log.error("Drive teardown failure for %s",
Line 2545:                                    drive, exc_info=True)


-- 
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list