Change in vdsm[master]: avoid redundant domain produce() in createStoragePool

fsimonce at redhat.com fsimonce at redhat.com
Tue Dec 3 21:56:25 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: avoid redundant domain produce() in createStoragePool
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

I like the idea but the implementation has a problem that should be addressed.

....................................................
File vdsm/storage/sp.py
Line 561:                 # Non ISO domains have only 1 pool
Line 562:                 if len(spUUIDs) > 0:
Line 563:                     raise se.StorageDomainAlreadyAttached(spUUIDs[0], sdUUID)
Line 564: 
Line 565:             if domain.isData() and (domain.getVersion() != msdVersion):
This works only if the master domain is the first domain in domList, otherwise it will break on msdVersion not being defined.
Line 566:                 raise se.MixedSDVersionError(domain.sdUUID, domain.getVersion(), msd.sdUUID, msdVersion)
Line 567: 
Line 568:         fileUtils.createdir(self.poolPath)
Line 569:         self._acquireTemporaryClusterLock(msdUUID, safeLease)


-- 
To view, visit http://gerrit.ovirt.org/7347
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1c236aa3043068ca8f3f376cb340e986cd484bb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list