Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge This hoo...

danken at redhat.com danken at redhat.com
Mon Dec 2 20:42:42 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: hooks: macbind - Attach vm nics to specified bridge This hook support binding specified mac address to custom/other bridge than the currently defined bridge in ovirt. This hook is also capable of binding a mac address to openvswitch bridge.
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Thanks for this hook. I'd like to have this functionality. But if we are to maintain the hook, I should understand why per-nic is not feasible. http://gerrit.ovirt.org/#/c/17895/1/vdsm_hooks/macbind/README does not answer me.

....................................................
Commit Message
Line 3: AuthorDate: 2013-08-11 12:45:33 +0530
Line 4: Commit:     Humble Chirammal <hchiramm at redhat.com>
Line 5: CommitDate: 2013-12-02 18:21:56 +0530
Line 6: 
Line 7: hooks: macbind - Attach vm nics to specified bridge
Add a newline between subject and content.

Please use the new per-device custom properties (then it would work for hot plugged nic too), or explain why you cannot.
Line 8: This hook support binding specified
Line 9: mac address to custom/other bridge than the currently defined
Line 10: bridge in ovirt. This hook is also capable of binding
Line 11: a mac address to openvswitch bridge.


-- 
To view, visit http://gerrit.ovirt.org/17895
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Humble Devassy Chirammal <hchiramm at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Humble Devassy Chirammal <hchiramm at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list