Change in vdsm[master]: vdsm-hooks: fix malformed libvirt xml

sgotliv at redhat.com sgotliv at redhat.com
Mon Dec 2 14:39:31 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: vdsm-hooks: fix malformed libvirt xml
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

....................................................
Commit Message
Line 4: Commit:     Amador Pahim <apahim at redhat.com>
Line 5: CommitDate: 2013-12-02 09:58:01 -0300
Line 6: 
Line 7: vdsm-hooks: fix malformed libvirt xml
Line 8: 
This is not a malformed xml. 

This patch is preventing creation of a snapshot of direct lun, right?
Line 9: Missing snapshot="no" attribute is leding Storage Live Migration
Line 10: to fail.
Line 11: This patch adds snapshot="no" attribute to vdsm-hooks adding
Line 12: disks/directlun.


Line 6: 
Line 7: vdsm-hooks: fix malformed libvirt xml
Line 8: 
Line 9: Missing snapshot="no" attribute is leding Storage Live Migration
Line 10: to fail.
s/leding/leading
Line 11: This patch adds snapshot="no" attribute to vdsm-hooks adding
Line 12: disks/directlun.
Line 13: 
Line 14: Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a


Line 8: 
Line 9: Missing snapshot="no" attribute is leding Storage Live Migration
Line 10: to fail.
Line 11: This patch adds snapshot="no" attribute to vdsm-hooks adding
Line 12: disks/directlun.
Adding disks.
Line 13: 
Line 14: Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a
Line 15: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036111


-- 
To view, visit http://gerrit.ovirt.org/21913
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list