Change in vdsm[master]: vdsClient: manage vdsm.conf

ybronhei at redhat.com ybronhei at redhat.com
Sun Dec 1 16:26:24 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsClient: manage vdsm.conf
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-11-29 19:26:44 -0500
Line 4: Commit:     Douglas Schilling Landgraf <dougsland at redhat.com>
Line 5: CommitDate: 2013-11-29 19:26:44 -0500
Line 6: 
Line 7: vdsClient: manage vdsm.conf
please change- new vdsClient API to manage vdsm configuration
Line 8: 
Line 9: A user reported that would like to have option in vdsClient to
Line 10: show the current settings. Additionaly to this option, created a flag
Line 11: to update vdsm config file.


Line 7: vdsClient: manage vdsm.conf
Line 8: 
Line 9: A user reported that would like to have option in vdsClient to
Line 10: show the current settings. Additionaly to this option, created a flag
Line 11: to update vdsm config file.
1. no need to mention that user requests for it. 

2.if we created the configurator module, and vdsm-tool uses it and should "config" and do such administrator's management operations, so.. why not do it there? vdsClient is to manage vdsm verbs while vdsm is running..
Line 12: 
Line 13: Change-Id: I81c3f2d2588d3963c66bad42e469e78f1393104b


....................................................
File client/vdsClient.py
Line 25: import re
Line 26: import socket
Line 27: import pprint as pp
Line 28: 
Line 29: from ConfigParser import ConfigParser
the logic should not be here.. put it in config.py and call it if you keep it vdsClient verb
Line 30: from datetime import datetime
Line 31: from vdsm import vdscli
Line 32: from shutil import copy2
Line 33: try:


Line 28: 
Line 29: from ConfigParser import ConfigParser
Line 30: from datetime import datetime
Line 31: from vdsm import vdscli
Line 32: from shutil import copy2
vdsm imports at last, import shutil before
Line 33: try:
Line 34:     import vdsClientGluster as ge
Line 35:     _glusterEnabled = True
Line 36: except ImportError:


-- 
To view, visit http://gerrit.ovirt.org/21876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81c3f2d2588d3963c66bad42e469e78f1393104b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list