Change in vdsm[master]: clientIF: Decouple HSM and clientIF

ybronhei at redhat.com ybronhei at redhat.com
Sun Dec 1 15:34:07 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: clientIF: Decouple HSM and clientIF
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/clientIF.py
Line 72:         self._networkSemaphore = threading.Semaphore()
Line 73:         self._shutdownSemaphore = threading.Semaphore()
Line 74:         self.irs = irs
Line 75:         if self.irs:
Line 76:             self.irs.registerDomainStateChangeCallback(self.contEIOVms)
fix: so replace it everywhere with set/getIrs() if it appears all around the code, and getIrs which should kill vdsm if irs is none
Line 77:         self.log = log
Line 78:         self._recovery = True
Line 79:         self.channelListener = Listener(self.log)
Line 80:         self._generationID = str(uuid.uuid4())


-- 
To view, visit http://gerrit.ovirt.org/21877
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09aba3638d0dcf5aef73864dd0fe8eae1ced70b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list