Change in vdsm[master]: gluster: bug fix for listing and adding hook

tjeyasin at redhat.com tjeyasin at redhat.com
Thu Aug 29 11:22:08 UTC 2013


Timothy Asir has posted comments on this change.

Change subject: gluster: bug fix for listing and adding hook
......................................................................


Patch Set 3:

(2 comments)

....................................................
File vdsm/gluster/hooks.py
Line 245:             enable=False):
Line 246:     hookPath = os.path.join(_glusterHooksPath, glusterCmd, hookLevel)
Line 247:     if not os.path.isdir(hookPath):
Line 248:         try:
Line 249:             # create directory if it doesn't exist
I will remove this line
Line 250:             os.makedirs(hookPath)
Line 251:         except OSError as e:
Line 252:             errMsg = "[Errno %s] %s: '%s'" % (e.errno, e.strerror, e.filename)
Line 253:             raise ge.GlusterHookAddFailedException(err=[errMsg])


Line 246:     hookPath = os.path.join(_glusterHooksPath, glusterCmd, hookLevel)
Line 247:     if not os.path.isdir(hookPath):
Line 248:         try:
Line 249:             # create directory if it doesn't exist
Line 250:             os.makedirs(hookPath)
yes its created with correct owner and permission (0755).
I will add only the required selinux attribute for this directory.

security.selinux="system_u:object_r:var_lib_t:s0"
Line 251:         except OSError as e:
Line 252:             errMsg = "[Errno %s] %s: '%s'" % (e.errno, e.strerror, e.filename)
Line 253:             raise ge.GlusterHookAddFailedException(err=[errMsg])
Line 254: 


-- 
To view, visit http://gerrit.ovirt.org/18345
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I470470da153edef3fe7eb3a7d41a775bac208449
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list