Change in vdsm[master]: gluster: geo replication status and status detail

dnarayan at redhat.com dnarayan at redhat.com
Thu Aug 29 09:31:37 UTC 2013


ndarshan has posted comments on this change.

Change subject: gluster: geo replication status and status detail
......................................................................


Patch Set 1:

(3 comments)

....................................................
Commit Message
Line 8: 
Line 9: this has two verbs, status: provides geo-replication status of all running
Line 10: sessions or all sessions associated with a perticular source volume or
Line 11: session between a source and remote volume. status detail: provides detailed
Line 12: status of geo-repliction session between source and remote volume
Done
Line 13: 
Line 14: Change-Id: I4f37f35a5480fbe049a67758e122d4a0c2eba513


....................................................
File vdsm/gluster/cli.py
Line 905:               'uptime': tree.find('geoRep/uptime').text,
Line 906:               'filesSyncd': tree.find('geoRep/filesSyncd').text,
Line 907:               'filesPending': tree.find('geoRep/filesPending').text,
Line 908:               'bytesPending': tree.find('geoRep/bytesPending').text,
Line 909:               'deletesPending': tree.find('geoRep/deletesPending').text}
"geo-replication status detail"  command gives the status detail only between a specified master ans a slave and the master name and slave name is to be specified by the user. As the user will be checking detail between master and a slave, so I think they are missing.
Line 910:     return status
Line 911: 
Line 912: 
Line 913: def _parseGeoRepStatus(tree):


Line 943: def volumeGeoRepStatusDetail(volName, remoteHost, remoteVolName,
Line 944:                              ):
Line 945:     command = _getGlusterVolCmd() + ["geo-replication", volName,
Line 946:                                      "%s::%s" % (remoteHost, remoteVolName),
Line 947:                                      "status", "detail"]
For "geo-replication status" command master name and slave name are optional as it can provide status of all geo-rep sessions/geo-rep session between a specified master and all slave/geo-rep session between a specified master and slave.
But for "geo-replication status detail" command both arguments are compulsory as it gives status only between a specified master and slave.

For simplicity of handling the arguments I made it as seperate functions. If you still feel it is better to have a single function I will do it.
Line 948:     try:
Line 949:         xmltree = _execGlusterXml(command)
Line 950:     except ge.GlusterCmdFailedException as e:
Line 951:         raise ge.GlusterGeoRepStatusDetailFailedException(rc=e.rc, err=e.err)


-- 
To view, visit http://gerrit.ovirt.org/18414
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f37f35a5480fbe049a67758e122d4a0c2eba513
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ndarshan <dnarayan at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: ndarshan <dnarayan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list