Change in vdsm[master]: vdsmd and supervdsmd: extract common init tasks and add init...

Alon Bar-Lev alonbl at redhat.com
Thu Aug 29 08:53:51 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: vdsmd and supervdsmd: extract common init tasks and add init adapter
......................................................................


Patch Set 20:

(1 comment)

....................................................
File vdsm/vdsmd.init.in
Line 102:         if [ "${ret_val}" -ne 0 ]; then
Line 103:             log_failure_msg "${prog}: Start dependent ${srv}"
Line 104:             return "${ret_val}"
Line 105:         fi
Line 106:     done
I did not understand what service.py is...

there is a different, I think, between a logic, such as libvirt configuration, which is application specific anyway and the ability to maintain sane init.d script.

what you are recommending is to place #ifdef for every distribution within the vdsm code and provide abstraction for a functionality that does not require abstraction.

It will also easier for downstream maintainer to maintain the initscript and fix issues if exists if it is not tied within the application logic.

the vdsm-tool start/stop functionality is very handy as far as documentation is concerned... you can have one command documented instead of per distribution... it also easier to support people this way... as you do not ask them what distro they are running, just tell them to execute vdsm-tool restart for example.

but when it comes down to actual maintenance these abstraction are harder to understand.
Line 107: }
Line 108: 
Line 109: test_already_running()
Line 110: {


-- 
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list