Change in vdsm[master]: Rename Image.copy() to Image.collapse().

sgotliv at redhat.com sgotliv at redhat.com
Wed Aug 28 17:26:18 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: Rename Image.copy() to Image.collapse().
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

....................................................
Commit Message
Line 4: Commit:     Eduardo Warszawski <ewarszaw at redhat.com>
Line 5: CommitDate: 2013-08-28 14:18:22 +0300
Line 6: 
Line 7: Rename Image.copy() to Image.collapse().
Line 8: 
The new name is "copyCollapsed", right?
Line 9: Renaming this method in order to clarify it's result and
Line 10: differentiate it from dict.copy()
Line 11: 
Line 12: Change-Id: I4b6ec44430465097baf4dd5a2e5bdf6e3842a33f


-- 
To view, visit http://gerrit.ovirt.org/18232
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6ec44430465097baf4dd5a2e5bdf6e3842a33f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list