Change in vdsm[master]: Making getVSize and getTrueSize SD methods.
ykaplan at redhat.com
ykaplan at redhat.com
Wed Aug 28 15:39:33 UTC 2013
Yeela Kaplan has posted comments on this change.
Change subject: Making getVSize and getTrueSize SD methods.
......................................................................
Patch Set 3: Code-Review-1
(3 comments)
....................................................
File vdsm/storage/blockSD.py
Line 609: except se.LogicalVolumeDoesNotExistError:
Line 610: return False
Line 611: return True
Line 612:
Line 613: def getVSize(self, imgUUID, volUUID, bs=BLOCK_SIZE):
BLOCK_SIZE is not defined here,
either define or take from blockVolume
Line 614: """ Returns size in block units.
Line 615:
Line 616: Returns the largest integer value less than or equal to size [blocks].
Line 617: """
....................................................
File vdsm/storage/fileSD.py
Line 285: """
Line 286: volPath = os.path.join(imgPath, volUUID)
Line 287: return self.oop.fileUtils.pathExists(volPath)
Line 288:
Line 289: def getVSize(self, imgUUID, volUUID, bs=BLOCK_SIZE):
BLOCK_SIZE is not defined here also.
Line 290: volPath = os.path.join(self.mountpoint, self.sdUUID, 'images',
Line 291: imgUUID, volUUID)
Line 292: return int(self.oop.os.stat(volPath).st_size / bs)
Line 293:
Line 287: return self.oop.fileUtils.pathExists(volPath)
Line 288:
Line 289: def getVSize(self, imgUUID, volUUID, bs=BLOCK_SIZE):
Line 290: volPath = os.path.join(self.mountpoint, self.sdUUID, 'images',
Line 291: imgUUID, volUUID)
maybe create getVolPath()???
Line 292: return int(self.oop.os.stat(volPath).st_size / bs)
Line 293:
Line 294: def getVTrueSize(self, imgUUID, volUUID, bs=BLOCK_SIZE):
Line 295: volPath = os.path.join(self.mountpoint, self.sdUUID, 'images',
--
To view, visit http://gerrit.ovirt.org/18202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9772cedd74431e71d6068399546e1b4aae69e9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list