Change in vdsm[master]: Remove block size validation from blockSD instatiation.

ewarszaw at redhat.com ewarszaw at redhat.com
Wed Aug 28 08:29:31 UTC 2013


Eduardo has posted comments on this change.

Change subject: Remove block size validation from blockSD instatiation.
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/storage/blockSD.py
Line 406:             # *blkSize keys may be missing from metadata only for domains that
Line 407:             # existed before the introduction of the keys.
Line 408:             # Such domains supported only 512 sizes
Line 409:             self.logBlkSize = 512
Line 410:             self.phyBlkSize = 512
SDs will be discovered when we are connecting to the storage (the test was moved there) or when creating a new SD on the disk which is done with luns of uniform size.
There are not other known ways to get an SD and is assumed the sizes are  constant, therefore there is no need to check it in each instantiation.
Line 411: 
Line 412:         # _extendlock is used to prevent race between
Line 413:         # VG extend and LV extend.
Line 414:         self._extendlock = threading.Lock()


-- 
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list