Change in vdsm[master]: Allow configurators to be used as context managers

danken at redhat.com danken at redhat.com
Tue Aug 27 14:08:36 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Allow configurators to be used as context managers
......................................................................


Patch Set 3:

(1 comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 46:         super(Ifcfg, self).__init__(ConfigWriter())
Line 47: 
Line 48:     def begin(self):
Line 49:         if self.configApplier is None:
Line 50:             self.configApplier = ConfigWriter()
this removal is in this patch only to confuse me, right?
Line 51: 
Line 52:     def rollback(self):
Line 53:         self.configApplier.restoreBackups()
Line 54:         self.configApplier = None


-- 
To view, visit http://gerrit.ovirt.org/18412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c07aa23d637ad3ae8a8b5ce455e67b163338ca8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list