Change in vdsm[master]: Unified network persistence [1/3] - Save running config

amuller at redhat.com amuller at redhat.com
Tue Aug 27 14:06:31 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Unified network persistence [1/3] - Save running config
......................................................................


Patch Set 18:

(1 comment)

....................................................
File vdsm/configNetwork.py
Line 172:         runningConfig = RunningConfig()
Line 173:         bonding = attrs.get('bonding')
Line 174:         if bonding:
Line 175:             bondAttrs = {'nics': attrs.pop('nics')}
Line 176:             bondingOptions = attrs.pop('bondingOptions', None)
Special care needs to be taken if the bond options should be saved as 'options' or 'bondingOptions'. Currently if a bond was added via setupNetworks the running conf saves it as 'bondingOptions'.
Line 177:             if bondingOptions:
Line 178:                 bondAttrs['bondingOptions'] = bondingOptions
Line 179:             runningConfig.setBonding(bonding, bondAttrs)
Line 180:         else:


-- 
To view, visit http://gerrit.ovirt.org/16699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Ĺ ebek <psebek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list