Change in vdsm[master]: vdsm: Fix potential leak in Vm.destroy()

mbetak at redhat.com mbetak at redhat.com
Tue Aug 27 13:51:37 UTC 2013


Martin Betak has posted comments on this change.

Change subject: vdsm: Fix potential leak in Vm.destroy()
......................................................................


Patch Set 1:

Git blame traced this back to the initial commit by 'Tabula Rasa' so no help there. But my concern was that if the deleteVm was not called, then this line:
 del self.cif.vmContainer[self.conf['vmId']]
would not get executed and we could see VM's piling up in the container which should have been deleted.

-- 
To view, visit http://gerrit.ovirt.org/18337
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b5599e04e49afa53d1384eb386215efd467e00e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list