Change in vdsm[master]: cleanup of vm.py

tjeyasin at redhat.com tjeyasin at redhat.com
Tue Aug 27 10:59:34 UTC 2013


Timothy Asir has posted comments on this change.

Change subject: cleanup of vm.py
......................................................................


Patch Set 12:

(2 comments)

....................................................
File vdsm/vm.py
Line 1805:                    CONSOLE_DEVICES: [],
Line 1806:                    SMARTCARD_DEVICES: []}
Line 1807:         # Build devices structure
Line 1808:         if self.conf.get('devices') is not None:
Line 1809:             for dev in self.conf.get('devices'):
can a dev could be empty or will it have some values always?
Line 1810:                 try:
Line 1811:                     devices[dev['type']].append(dev)
Line 1812:                 except KeyError:
Line 1813:                     # Unknown type device found


Line 1809:             for dev in self.conf.get('devices'):
Line 1810:                 try:
Line 1811:                     devices[dev['type']].append(dev)
Line 1812:                 except KeyError:
Line 1813:                     # Unknown type device found
I find this comment obvious.
Line 1814:                     self.log.warn("Unknown type found, device: '%s' "
Line 1815:                                   "found", dev)
Line 1816:                     devices[GENERAL_DEVICES].append(dev)
Line 1817:         else:


-- 
To view, visit http://gerrit.ovirt.org/18047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2712148b670c9f85beaea40a0b2e870d829b2b4b
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list