Change in vdsm[master]: Unified network persistence [3/3] - Restore network configur...

psebek at redhat.com psebek at redhat.com
Tue Aug 27 07:12:12 UTC 2013


Petr Šebek has posted comments on this change.

Change subject: Unified network persistence [3/3] - Restore network configuration
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

....................................................
File vdsm/vdsm-restore-net-config
Line 44:     for network in networks:
Line 45:         removeNetworks[network] = {'remove': True}
Line 46:     logging.debug("Removing all networks in running config: %s" %
Line 47:                   removeNetworks)
Line 48:     setupNetworks(removeNetworks, {}, **{'connectivityCheck': False})
I think that
  setupNetworks(removeNetworks, {}, connectivityCheck=False)
would look better.
Line 49: 
Line 50:     persistentConfig = PersistentConfig()
Line 51:     nets = persistentConfig.getNetworks()
Line 52:     bonds = persistentConfig.getBondings()


Line 51:     nets = persistentConfig.getNetworks()
Line 52:     bonds = persistentConfig.getBondings()
Line 53:     logging.debug("Calling setupNetworks with networks: %s, bondings: %s" %
Line 54:                   (nets, bonds))
Line 55:     setupNetworks(nets, bonds, **{'connectivityCheck': False})
Same here
Line 56: 
Line 57: 
Line 58: def main():
Line 59:     try:


-- 
To view, visit http://gerrit.ovirt.org/17010
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Šebek <psebek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list