Change in vdsm[master]: gluster: Get size information of a gluster volume

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Tue Aug 27 06:40:49 UTC 2013


Deepak C Shetty has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
......................................................................


Patch Set 5:

(1 comment)

Another option could be do a readonly mount in a hidden dir and do 'df -h' whenever u need the latest stats. thats possible too... I know its not perfect tho!

....................................................
File vdsm.spec.in
Line 1271: %dir %{_datadir}/%{vdsm_name}/gluster
Line 1272: %doc COPYING
Line 1273: %{_datadir}/%{vdsm_name}/gluster/api.py*
Line 1274: %{_datadir}/%{vdsm_name}/gluster/vdsmapi-gluster-schema.json
Line 1275: %{_datadir}/%{vdsm_name}/gluster/gfapi.py*
I will suggest then not to use the name as gfapi.py, since thats misleading and wrong.
Maybe say statvfs.py or have gluster/gfapi/stavfs.py .. that looks more logical considering that u don't plan to support everything via gfapi. 

Any reason why u r putting this in vdsm-gluster pkg and not in -api pkg ?
Since gfapi.py needs libgfapi.so.XX it should be part of -api pkg, in which case, the vdsm pkg itself can make use of it in future as needed.
Line 1276: %{_datadir}/%{vdsm_name}/gluster/hooks.py*
Line 1277: %{_datadir}/%{vdsm_name}/gluster/services.py*
Line 1278: %endif
Line 1279: 


-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list