Change in vdsm[master]: Unified network persistence [1/3] - Save running config

asegurap at redhat.com asegurap at redhat.com
Mon Aug 26 12:37:39 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Unified network persistence [1/3] - Save running config
......................................................................


Patch Set 18:

(1 comment)

....................................................
File lib/vdsm/unifiedpersistence.py
Line 44:     def _getConfig(self, path):
Line 45:         try:
Line 46:             with open(path, 'r') as configurationFile:
Line 47:                 return json.load(configurationFile)
Line 48:         except IOError as ose:
ose stands for OSError :P. We should change this to ioe
Line 49:             if ose.errno == os.errno.ENOENT:
Line 50:                 logging.debug('Unified persistence: Network entity at '
Line 51:                               '%s not found' % path)
Line 52:                 return {}


-- 
To view, visit http://gerrit.ovirt.org/16699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Ĺ ebek <psebek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list