Change in vdsm[master]: Remove redundant check that causes lvm cache to refresh ever...
ykaplan at redhat.com
ykaplan at redhat.com
Mon Aug 26 12:17:45 UTC 2013
Yeela Kaplan has posted comments on this change.
Change subject: Remove redundant check that causes lvm cache to refresh every volume creation
......................................................................
Patch Set 4:
(1 comment)
....................................................
File vdsm/storage/remoteFileHandler.py
Line 352: if creatExcl:
Line 353: flags |= os.O_EXCL
Line 354:
Line 355: fd = os.open(path, flags)
Line 356: with os.fdopen(fd, 'w') as f:
Yes,
Thank you for the suggestion, I've considered both, but I really really like the 'with' statement.
Line 357: if mode is not None:
Line 358: os.chmod(path, mode)
Line 359: f.truncate(size)
Line 360:
--
To view, visit http://gerrit.ovirt.org/18274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f3b6ca8313070d0345b5f76ebb0b3d9772d14f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list