Change in vdsm[master]: vdsmd and supervdsmd: extract common init tasks and add init...

Alon Bar-Lev alonbl at redhat.com
Mon Aug 26 09:17:14 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: vdsmd and supervdsmd: extract common init tasks and add init adapter
......................................................................


Patch Set 19:

(1 comment)

....................................................
File vdsm/systemd-vdsmd.in
Line 23:     exit 1
Line 24: fi
Line 25: 
Line 26: shift
Line 27: "@LIBEXECDIR@/vdsmd_init_common.sh" --reconfigure "$@"
right.

Just for fun... :)

 [ "$1" != "reconfigure" ] && die "only reconfigure is supported"
 [ -n "$2" -a "$2" != "force" ] && die "only force is supported"
 vdsm-tool libvirt-configure ${2:+--force}

And if the patch is rejected, I will create another one to add vdsm-tool configure to call whatever configuration required. So the logic will be the same just 's/libvirt-configure/configure/'


-- 
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list