Change in vdsm[master]: Unified network persistence [3/3] - Restore network configur...

asegurap at redhat.com asegurap at redhat.com
Mon Aug 26 08:05:52 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Unified network persistence [3/3] - Restore network configuration
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

....................................................
File vdsm/vdsm-restore-net-config
Line 51:             netinfo.BOND_CONF_PERS_DIR + bondFile))
Line 52: 
Line 53:     logging.debug("Calling setupNetworks with networks: %s, bondings: %s" %
Line 54:                   (nets, bonds))
Line 55:     setupNetworks(nets, bonds)
I think you should do something about the connectivityCheck
Line 56: 
Line 57: 
Line 58: def main():
Line 59:     try:


Line 57: 
Line 58: def main():
Line 59:     try:
Line 60:         logging.config.fileConfig("/etc/vdsm/svdsm.logger.conf")
Line 61:     except:
except Exception, rather than catching baseExceptions?
Line 62:         logging.basicConfig(filename='/dev/stdout', filemode='w+',
Line 63:                             level=logging.DEBUG)
Line 64:         logging.error("Could not init proper logging", exc_info=True)
Line 65: 


-- 
To view, visit http://gerrit.ovirt.org/17010
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Ĺ ebek <psebek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list