Change in vdsm[master]: Enhanced netinfo.getBootProtocol

amuller at redhat.com amuller at redhat.com
Sun Aug 25 18:36:24 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Enhanced netinfo.getBootProtocol
......................................................................


Patch Set 1:

(1 comment)

....................................................
File lib/vdsm/netinfo.py
Line 456:         return getIfaceCfg(iface).get('BOOTPROTO')
Line 457: 
Line 458:     # TODO: This method doesn't work if the device doesn't have an ip
Line 459:     # configuration or if NetworkManager is enabled
Line 460:     elif persistence == 'unified':
We can, I had a brain fart.

We still need this method for the upgrade script though, but getVdsCaps can report from the running conf instead of reporting the ifcfg file in the future...
Line 461:         return 'dhcp' if os.path.isfile("/var/run/dhclient-%s.pid" % iface) \
Line 462:             else 'none'
Line 463: 
Line 464: 


-- 
To view, visit http://gerrit.ovirt.org/18484
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list