Change in vdsm[master]: vm: new parameter 'protected' for vm creation

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Aug 25 09:24:18 UTC 2013


Eduardo has posted comments on this change.

Change subject: vm: new parameter 'protected' for vm creation
......................................................................


Patch Set 4: Code-Review-1

Please consider:


The shared element is optional and actually sent by the engine by default 'false'.

IMHO it should be used for shared = ('Exclusive', 'Shared', 'None') and we do not need extra parameters, since is sent today by default 'false'.
For BC (using use_volume_leases) set:
None if shared == 'false'.
'Shared' if shared == 'True'

Instead 'protected', the VM protected, will sent 'Exclusive'.


The required changes are minimal, in getConfDrives() set the default to None and in getXML() acting properly.
And changing the engine default when you want VMs being protected by default.

-- 
To view, visit http://gerrit.ovirt.org/17714
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9429ead45caac1178957a33393642817db59508f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list