Change in vdsm[master]: vdsmd and supervdsmd: extract common init tasks and add init...

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Fri Aug 23 03:45:11 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: vdsmd and supervdsmd: extract common init tasks and add init adapter
......................................................................


Patch Set 18: -Verified

(1 comment)

....................................................
File vdsm/vdsmd.init.in
Line 83:     fi
Line 84: 
Line 85:     "${VDSMD_INIT_COMMON}" --shutdown-conflicting-srv "${CONFLICTING_SERVICES}"
Line 86: 
Line 87:     "${VDSMD_INIT_COMMON}" --start-needed-srv "${NEEDED_SERVICES}"
I thought LSB init scripts do not support declaration of conflicting service. I also see lsb headers in RHEL init.d services, so I thought RHEL support LSB init headers as well, am I wrong? In fact I was curious about why we did not use lsb header and implement start_needed_srv in vdsmd.init.in.

The reason to use a common start_need_srv is that in a considerable amount of time, there would be no downstream packagers really. All the scripts will be maintained ourselves. So I think it's better not to duplicate similar code in SysV and Upstart scripts to ease the work of VDSM developers.

I'm not against using downstream specific method. Because when submitting the package to official repository of Debian or Ubuntu, their maintainers can easily understand the downstream specific commands, and it fits into their policy, probably. I was saying that since we are using downstream specific commands, shouldn't we address explicitly for which downstream distro this file is? That's why I suggest init/sysv/rhel6-vdsmd.init.in, init/sysv/debian-vdsmd.init.in . From what I can see, your point is there is no need to do this explicitly, vdsmd.init.in is just a hint to downstream packagers. If I understand you correctly, your reason seems not a big problem for me, just fine.

Since there is no other comments, I'll take your advice and update the patch.
Line 88: 
Line 89:     "${VDSMD_INIT_COMMON}" --pre-start
Line 90: 
Line 91:     echo $"Starting up vdsm daemon: "


-- 
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list