Change in vdsm[master]: Allow configurators to be used as context managers

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Fri Aug 23 03:28:26 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Allow configurators to be used as context managers
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 50:             self.configApplier = ConfigWriter()
Line 51: 
Line 52:     def rollback(self):
Line 53:         self.configApplier.restoreBackups()
Line 54:         self.configApplier = None
are you going to make long living configurator across api verb?
otherwise,  we could a simple 'pass' is enough for ifcfg's  begin and commit.
Line 55: 
Line 56:     def commit(self):
Line 57:         self.configApplier = None
Line 58: 


-- 
To view, visit http://gerrit.ovirt.org/18412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c07aa23d637ad3ae8a8b5ce455e67b163338ca8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list