Change in vdsm[master]: [2/3] Add "vlanid" to VLAN information

danken at redhat.com danken at redhat.com
Thu Aug 22 10:26:28 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: [2/3] Add "vlanid" to VLAN information
......................................................................


[2/3] Add "vlanid" to VLAN information

Currently vdsm does not report vlan id as an idependent field. ovirt-engine
is deducting vlan id by parsing vlan name, not reasonable as vlans can be
made with any name.
This patch adds the 'vlanid' information for vlans to be consumed by
ovirt-engine:

...
        vlans = {'eth0.10': {'addr': '',
                             'cfg': {},
                             'iface': 'eth0',
                             'ipv6addrs': [],
                             'mtu': '1500',
                             'netmask': '',
                             'vlanid': 10},
                 'eth0.myvlan': {'addr': '',
                                 'cfg': {},
                                 'iface': 'eth0',
                                 'ipv6addrs': [],
                                 'mtu': '1500',
                                 'netmask': '',
                                 'vlanid': 20}}

...

Change-Id: I6c83a7639bd4219771df0c7b3dd41b8f9806e9f1
Signed-off-by: Amador Pahim <apahim at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/18181
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netinfo.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Amador Pahim: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18181
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c83a7639bd4219771df0c7b3dd41b8f9806e9f1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list